chore: more efficient access to FiberInterface epoch field #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
changed the title
romange
force-pushed
the
Pr2
branch
2 times, most recently
from
083d602 to
b803d2f
Compare
Done to improve efficiency of fiber context switch operations. Signed-off-by: Roman Gershman <[email protected]>
romange
changed the title
chakaz
reviewed
Mar 4, 2025
Comment on lines
+268
to
+270
| static __thread struct TL { | ||
| uint64_t epoch = 0; | ||
| } tl; |
There was a problem hiding this comment.
Why do you use a struct here instead of just static __thread uint64_t epoch_ = 0;?
There was a problem hiding this comment.
no strong reason, just a placeholder to move more "safe" fields.
There was a problem hiding this comment.
oh, gotcha, this is intended to (potentially) grow..
chakaz
approved these changes
Mar 4, 2025
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve efficiency of fiber context switch operations.