Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working till Android Studio 1 rc2 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aexyn
Copy link

@Aexyn Aexyn commented Nov 27, 2014

gradle plugin upgraded to 0.14.4
gradle updtaed to 2.2.1
project backported to work on kitkat and above

gradle updtaed to 2.2.1
project backported to work on kitkat and above
@romainguy
Copy link
Owner

Thanks for the pull request. I'm targeting the version of Android Studio available from http://developer.android.com/sdk/installing/studio.html, currently 0.8.14 (beta channel). I'll update the project files once 1.0 or an RC hits this channel.

I've also left comments on your change to the activity.

@@ -49,17 +58,17 @@
}

private final State[] mStates = {
new State(R.color.az, R.raw.map_az, new int[] {
new State(R.color.az, R.raw.map_az, new int[]{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a lot of style changes and added a lof of empty lines. I don't wish to change the style of this file (it would be inconsistent with the rest of the project too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants