Fixes Rails 7.2 dep warning #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should check for the rails version then |
bendangelo
force-pushed
the
fixes-7.2-rails
branch
from
109ee6d
to
112f41e
Compare
|
Ok done. |
flash-gordon
requested changes
Jun 29, 2024
Comment on lines
+36
to
+41
| def color_option | ||
| if Gem::Version.new(Rails::VERSION::STRING) >= Gem::Version.new('7.1') | ||
| { color: true } | ||
| else | ||
| true | ||
| end |
There was a problem hiding this comment.
I have two suggestions
- You can assign it to a constant
COLOR_OPTION = if ...will work just as fine but with only 1 check rather than a check per every call - You use
Railsconstant but the plugin depends on active-support, you should check its version instead. For instance, I have a project where active-support is present but rails isn't.
flash-gordon
added a commit
that referenced
this pull request
Jul 1, 2024
Co-Authored-By: Ben D'Angelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated argument to color: true. This stops the rails 7.2 dep warning.