Skip to content

Commit

Permalink
chore: update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
sapphi-red committed Nov 19, 2024
1 parent f02631c commit 6cae00e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions playground/resolve/__tests__/resolve.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,12 @@ test('Resolve browser field even if module field exists', async () => {
expect(await page.textContent('.browser-module1')).toMatch('[success]')
})

// vite is behaving bad here
// should not fallback
test.skip('Resolve module field if browser field is likely UMD or CJS', async () => {
expect(await page.textContent('.browser-module2')).toMatch('[success]')
})

// vite is behaving bad here
// should not fallback
test.skip('Resolve module field if browser field is likely IIFE', async () => {
expect(await page.textContent('.browser-module3')).toMatch('[success]')
})
Expand Down
4 changes: 2 additions & 2 deletions playground/resolve/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,11 @@ <h2>resolve non normalized absolute path</h2>
import browserModule1 from '@vitejs/test-resolve-browser-module-field1'
text('.browser-module1', browserModule1)

// vite is behaving bad here
// should not fallback
// import browserModule2 from '@vitejs/test-resolve-browser-module-field2'
// text('.browser-module2', browserModule2)

// vite is behaving bad here
// should not fallback
// import browserModule3 from '@vitejs/test-resolve-browser-module-field3'
// text('.browser-module3', browserModule3)

Expand Down

0 comments on commit 6cae00e

Please sign in to comment.