Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourcemap sources path relative to output file dirname #758

Merged
merged 7 commits into from
Apr 6, 2024

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Apr 5, 2024

Description

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 614b382
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/661002a53a42740007ddae2a

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 757c18b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6610e6b56a2d920008f24371

Copy link

codspeed-hq bot commented Apr 5, 2024

CodSpeed Performance Report

Merging #758 will not alter performance

Comparing fix-sourcemap-path (757c18b) with main (ee3739d)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.79%. Comparing base (ee3739d) to head (757c18b).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/rolldown_sourcemap/src/lib.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   79.78%   79.79%           
=======================================
  Files         127      127           
  Lines        6569     6582   +13     
=======================================
+ Hits         5241     5252   +11     
- Misses       1328     1330    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@underfin underfin marked this pull request as draft April 5, 2024 15:24
@hyf0 hyf0 self-assigned this Apr 5, 2024
@underfin underfin marked this pull request as ready for review April 6, 2024 06:07
@underfin underfin changed the title fix: sourcemap sources path relative to output dir fix: sourcemap sources path relative to output file dirname Apr 6, 2024
@hyf0 hyf0 merged commit 7f5047f into main Apr 6, 2024
23 checks passed
@hyf0 hyf0 deleted the fix-sourcemap-path branch April 6, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants