chore: isSupportedFormat ts ext name #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rolldown-rs canceled.
|
kazupon
reviewed
Mar 21, 2024
packages/rolldown/src/cli/utils.ts
Outdated
| @@ -23,5 +23,5 @@ export async function loadConfig( | |||
| */ | |||
| function isSupportedFormat(configPath: string): boolean { | |||
| const ext = path.extname(configPath) | |||
| return /\.(js|mjs)$/.test(ext) | |||
| return /\.(js|mjs|ts)$/.test(ext) | |||
There was a problem hiding this comment.
As commented here, we are currently not supporting the ts extension.
There was a problem hiding this comment.
Thank you for your reply. I see that error's prompt supports ts format, so do you think other logic optimizations can be merged? I can remove the rules of this ts type.
kazupon
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan