Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Linux support #4

wants to merge 1 commit into from

Conversation

xujialiang
Copy link

No description provided.

@xqbumu
Copy link
Contributor

xqbumu commented Dec 29, 2017

git是按行进行diff的,感觉单独做一个npm包放adb二进制文件好点,否则后面如果adb版本过多,.git会变的比较大

@yorkie
Copy link
Contributor

yorkie commented Dec 29, 2017

@xujialiang 嗯,正解,可以在每次模块安装时,下载对应的 ADB 包!

Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外把现在 osx 的 adb 工具重命名成 adb-darwin 吧?

@@ -34,7 +34,13 @@ init_adb() {
cd $(dirname `readlink -n $0`)
cd ../
local root=`pwd`
ADB=$root/tools/adb
local os = `uname -s`
ADB=$root/tools/adb-linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两行是不是多余的?

local os = `uname -s`
ADB=$root/tools/adb-linux
local os=`uname -s`
echo "os: $os"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行日志先去掉吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants