Add option to disable normalization of spec download URLs #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11d2f32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ctreatma is attempting to deploy a commit to the Rohit Gohri's projects Team on Vercel. A member of the Team first needs to authorize it. |
rohit-gohri
reviewed
Mar 20, 2025
packages/docusaurus-theme-redoc/src/theme/Redoc/ServerStyles.tsx
Outdated
Show resolved
Hide resolved
rohit-gohri
approved these changes
Mar 20, 2025
| }) { | ||
| const fullUrl = useBaseUrl(specProps.url, { absolute: true }); | ||
| const fullUrl = specProps.normalizeUrl ? useBaseUrl(specProps.url, { absolute: true }) : specProps.url; |
There was a problem hiding this comment.
I don't remember why I added absolute true, but thanks for keeping existing behaviour
packages/docusaurus-theme-redoc/src/theme/Redoc/ServerStyles.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rohit-gohri
reviewed
Mar 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
normalizeUrloption to the spec options so that plugin users can opt out of the behavior to convert spec download URLs to absolute URLs, which makes it possible to build a self-contained site. For backwards compatibility, thenormalizeUrlflag defaults to true.Fixes #400