Ensure SIGTERM leads to graceful termination in rocker/binder #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eitsupi thoughts on this? |
consideRatio
force-pushed
the
pr/make-sigterm-propegate
branch
from
e3d2d01 to
61d1c64
Compare
|
I did a force push. I saw that I had updated .json files incorrectly to reflect the changes in the Dockerfiles (left |
eitsupi
approved these changes
Mar 17, 2024
|
I've tested to startup the Dockerfile built just adjusting CMD as this PR does and it works fine, but I don't understand what I changed in the .json files. |
|
I have confirmed that the JSON file has now been changed without any problems. |
@cboettig you hold the ball to get this merged - ok to go? |
|
thanks for the ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771, not by introducing
tini, but by ensuring we don't letshbe the init process which in turn runsjupyter labwithout propegating SIGTERM to it.There may be a point to introduce
tinior similar, but from the SIGTERM perspective, this does the trick as well.This PR is modelled on for example https://github.com/rocker-org/rocker-versioned2/pull/740/files where I see that all Dockerfiles are updated along with a repsective .json file.