fix(zero-cache): handle subscribers ahead of the change-streamer change-log #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | darkgnotic/back-to-the-future |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 919.04 (-0.01%) | 937.47 (98.03%) |
| zero.js | 📈 view plot 🚷 view threshold | 171.32 (0.00%) | 174.75 (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 47.70 (0.00%) | 48.66 (98.04%) |
|
| Branch | darkgnotic/back-to-the-future |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 71.36 (-1.27%) | 69.67 (97.64%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 94.07 (-0.25%) | 90.75 (96.47%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
change-streamerforwards messages to view-syncers immediately, and concurrently stores and acks upstream, it is possible for a replica to be ahead of the change log if a server is killed before the change can be stored.Handle this case by considering the subscriber "caught up" if it is ahead of the change log. The existing forwarder logic already handles filtering out messages that have already been seen.
https://discord.com/channels/830183651022471199/1288232858795769917/1334328586265563260
https://discord.com/channels/830183651022471199/1332721644527157319