fix(replicache): If Replicache is closed, don't fire subscriptions (#…

…2591) This fixes the error at zbugs startup
rocicorp · Oct 8, 2024 · 3fa82e8 · 3fa82e8
1 parent 467cea5
commit 3fa82e8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/replicache/src/replicache-impl.ts b/packages/replicache/src/replicache-impl.ts
@@ -426,6 +426,7 @@ export class ReplicacheImpl<MD extends MutatorDefs = {}> {
     this.subscriptions = new SubscriptionsManagerImpl(
       this.#queryInternal,
       this.#lc,
+      this.#closeAbortController.signal,
     );
 
     const kvStoreProvider = getKVStoreProvider(this.#lc, options.kvStore);

diff --git a/packages/replicache/src/subscriptions.ts b/packages/replicache/src/subscriptions.ts
@@ -374,10 +374,16 @@ export class SubscriptionsManagerImpl implements SubscriptionsManager {
   readonly #queryInternal: QueryInternal;
   readonly #lc: LogContext;
   hasPendingSubscriptionRuns = false;
+  readonly #signal: AbortSignal;
 
-  constructor(queryInternal: QueryInternal, lc: LogContext) {
+  constructor(
+    queryInternal: QueryInternal,
+    lc: LogContext,
+    signal: AbortSignal,
+  ) {
     this.#queryInternal = queryInternal;
     this.#lc = lc;
+    this.#signal = signal;
   }
 
   add<R>(subscription: Subscription<R>): () => void {
@@ -406,6 +412,10 @@ export class SubscriptionsManagerImpl implements SubscriptionsManager {
     kind: InvokeKind.Type,
     diffs: DiffsMap | undefined,
   ) {
+    if (this.#signal.aborted) {
+      return;
+    }
+
     const subs = [...subscriptions] as readonly Subscription<unknown>[];
     if (subs.length === 0) {
       return;