Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pagination "onEachSide" #733

Conversation

romanwuensche
Copy link

$rows->onEachSide(1) was not working as expected in my project. Seems we have to use the full qualified namespace in the template for this to work:

before after

@robsontenorio
Copy link
Owner

Thanks for this!

I am delaying it for now because of upcoming maryUI v2 (daisyUI 5 + Tailwind 4).

@robsontenorio
Copy link
Owner

@romanwuensche I can't reproduce that using this simple query

$users = User::paginate(3);

How does it behaves for you?

@romanwuensche
Copy link
Author

Hi @robsontenorio. Still the same behavoir on my end. I will try a fresh install without anything special.

@robsontenorio
Copy link
Owner

Thanks for your contribution!

With the release of maryUI v2, I’m closing this. If you still think this should be merged, please create a new branch from main and submit it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants