Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated inference_slicer.py #839

Closed
wants to merge 4 commits into from
Closed

Updated inference_slicer.py #839

wants to merge 4 commits into from

Conversation

Bhavay-2001
Copy link
Contributor

Description

Fixes #781

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Testing needs to be done. Would like the maintainers to suggest changes

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Bhavay-2001
❌ Shubham Malhotra


Shubham Malhotra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Bhavay-2001
Copy link
Contributor Author

Hi @SkalskiP, can you please review this PR and let me know about the possible changes.

@SkalskiP
Copy link
Collaborator

SkalskiP commented Feb 1, 2024

Can you accept the CLA?

@Bhavay-2001
Copy link
Contributor Author

Yes, Done!

@Bhavay-2001
Copy link
Contributor Author

Hi @SkalskiP, can you please check now.
Thanks

@Bhavay-2001
Copy link
Contributor Author

I have signed the CLA but I am using my brother's laptop and he doesn't have a GitHub account, so how can I remove his name from this?

@SkalskiP
Copy link
Collaborator

SkalskiP commented Feb 1, 2024

You need to git config https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup with your GitHub nick and email BEFORE you commit code to branch.

@Bhavay-2001
Copy link
Contributor Author

Should I just delete this branch and add the changes from my own laptop with my settings?

@Bhavay-2001 Bhavay-2001 closed this Feb 1, 2024
@Bhavay-2001 Bhavay-2001 deleted the Inference_slicer_multiple_batches branch February 1, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InferenceSlicer] - allow batch size inference
3 participants