Add detailed OTel inference sub-spans and X-Trace-Id response header#2148
Open
Add detailed OTel inference sub-spans and X-Trace-Id response header#2148
Conversation
…response header - Add model.preprocess, model.predict, model.postprocess sub-spans to BaseInference.infer() to break down where inference time is spent - Add model.input_shape attribute to preprocess span - Add model.infer.caller attribute to distinguish async vs sync code paths - Return X-Trace-Id header in HTTP responses for easy trace lookup - Expose X-Trace-Id in CORS headers Generated with AI Co-Authored-By: AI <ai@example.com>
hansent
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
probicheaux and
yeldarby
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.preprocess,model.predict,model.postprocesschild spans insidemodel.inferto break down where inference time is spent (image decoding vs GPU execution vs NMS/formatting)model.input_shapeattribute on the preprocess span andmodel.infer.callerattribute to distinguish async vs sync FastAPI code pathsX-Trace-Idheader in HTTP responses so forced traces can be easily located in the collector without searchingTest plan
X-Force-Trace: trueand verifyX-Trace-Idis returned in response headersmodel.preprocess,model.predict,model.postprocess) appear in trace waterfall undermodel.infermodel.input_shapeandmodel.infer.callerattributes are populated