fix: resolve input image sub-property selector in workflow compiler (…#2138
Open
furai-ai wants to merge 1 commit intoroboflow:mainfrom
Open
fix: resolve input image sub-property selector in workflow compiler (…#2138furai-ai wants to merge 1 commit intoroboflow:mainfrom
furai-ai wants to merge 1 commit intoroboflow:mainfrom
Conversation
furai-ai
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
|
|
…oboflow#2113) When a workflow block references .image.name, the compiler failed to find the node in the execution graph because it passed the full selector string instead of the base input selector. Added get_input_selector_base() helper to strip sub-property suffix from input selectors before graph node lookup.
furai-ai
force-pushed
the
fix/input-image-name-selector-2113
branch
from
6350148 to
17073b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#2113)
What does this PR do?
Fixes the workflow compiler error when binding
$inputs.image.nameto the Dataset Upload block's image name field.
Root cause: When a selector like
$inputs.image.namewas used,the compiler passed the full string to
node_as()for graph lookup,but only
$inputs.imageexists as a node — causing anAssumptionError.Fix: Added
get_input_selector_base()helper incompiler/utils.pythat strips sub-property suffixes from input selectors before graph
node lookup. Used in
graph_constructor.pywhen resolving inputselector bindings.
Related Issue(s): Fixes #2113
Type of Change
Tests
Added two unit tests in
test_utils.pycovering:$inputs.image.name→ stripped to$inputs.image$inputs.image→ unchanged