Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unwanted print statement to input #315

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

thevickypedia
Copy link
Contributor

@thevickypedia thevickypedia commented Mar 3, 2024

Checklist

  • Added tests for changed code.
  • Updated documentation for changed code.
  • I've added a news fragment of my changes with the name,
    "{ISSUE_NUM}.{feature|bugfix|doc|removal|misc}""

Related Issue

Description

Moved the "Input mfa code:" within input statement

Reason:
There is no reason for the print statement to be stand-alone, as it will eventually be printed in the console for standard input in python

I'd also prefer pyrh using logger instead of print statements all over, but I'm not sure how you feel changing it. If it is a 👍🏻 , I can create a follow up PR for that as well. It doesn't need to be a static logger, pyrh can use a default logger and still give an option to users to bring their own formatted logger.

@adithyabsk adithyabsk merged commit e301e80 into robinhood-unofficial:master Mar 4, 2024
1 of 11 checks passed
@adithyabsk
Copy link
Member

Sure, happy to accept contributions to this project. But, fair warning--it's in maintenance mode these days. If you intend to land logic changes, would appreciate it if you could take a look at CI as well so we can merge with confidence.

@thevickypedia thevickypedia deleted the patch-1 branch March 4, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants