Skip to content

Commit

Permalink
Add protection to not make Pull requests in forked repos against the …
Browse files Browse the repository at this point in the history
…original Repository
  • Loading branch information
martyzz1 committed Jun 26, 2024
1 parent 5467c34 commit f10f38c
Showing 1 changed file with 41 additions and 11 deletions.
52 changes: 41 additions & 11 deletions gitfeatures/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,16 @@
seperator = os.environ.get("GITFEATURES_BRANCH_SEPERATOR", "_")
repo = os.environ.get("GITFEATURES_REPO", "github")
merge_strategy = os.environ.get("GITFEATURES_STRATEGY", "merge")
fork_pr_strategy = os.environ.get("GITFEATURES_FORK_PR_STRATEGY", "private")


def _call(args):
try:
return check_output(args).decode("utf-8")
except CalledProcessError:
sys.exit(__name__ + ": none zero exit status executing: " + " ".join(args)) # noqa
sys.exit(
__name__ + ": none zero exit status executing: " + " ".join(args)
) # noqa


def _get_branch_name(prefix, name):
Expand All @@ -42,7 +45,9 @@ def new_feature(name, prefix):
new_branch = _get_branch_name(prefix, name)

if _branch_exists(new_branch):
sys.exit(__name__ + ": local or remote branch already exists: " + new_branch) # noqa
sys.exit(
__name__ + ": local or remote branch already exists: " + new_branch
) # noqa

_call(["git", "checkout", "-b", new_branch])
_call(["git", "push", "-u", "origin", new_branch + ":" + new_branch])
Expand All @@ -59,11 +64,15 @@ def finish_feature(name, prefix):
branch = cur_branch
_call(["git", "checkout", master_branch])
else:
sys.exit(__name__ + ": please provide a branch name if on {}".format(master_branch))
sys.exit(
__name__ + ": please provide a branch name if on {}".format(master_branch)
)

_call(["git", "remote", "update", "origin"])

commits = _call(["git", "log", "--oneline", branch, "^origin/{}".format(master_branch)])
commits = _call(
["git", "log", "--oneline", branch, "^origin/{}".format(master_branch)]
)
if commits:
sys.exit(
__name__
Expand Down Expand Up @@ -136,10 +145,14 @@ def pullrequest(args):

# check its up to date with remote master if not pull
_call(["git", "remote", "update", "origin"])
commits = _call(["git", "log", "--oneline", "^" + branch, "origin/{}".format(master_branch)])
commits = _call(
["git", "log", "--oneline", "^" + branch, "origin/{}".format(master_branch)]
)
if commits:
print(
"Your branch is behind origin/{} so cannot be automatically {}d.".format(master_branch, merge_strategy)
"Your branch is behind origin/{} so cannot be automatically {}d.".format(
master_branch, merge_strategy
)
) # noqa
print(commits)
print(
Expand All @@ -153,9 +166,15 @@ def pullrequest(args):
_call(["git", "checkout", branch])
try:
print("git {} {}".format(merge_strategy, master_branch))
output = check_output(["git", merge_strategy, master_branch]).decode("utf-8")
output = check_output(["git", merge_strategy, master_branch]).decode(
"utf-8"
)
print(output)
print("Congratulations, successfully {}d {}".format(merge_strategy, master_branch))
print(
"Congratulations, successfully {}d {}".format(
merge_strategy, master_branch
)
)
except CalledProcessError as e:
if b"CONFLICT" in e.output:
err = (
Expand All @@ -176,19 +195,30 @@ def pullrequest(args):
_call(["git", "push", "origin", branch + ":" + branch])

origin = _call(["git", "config", "--get", "remote.origin.url"])
print("origin", origin)
name = origin.split(":")[1].replace(".git\n", "")
print("name", name)
print("branch", branch)
url = _get_pullrequest_url(name, branch)
if (len(args) > 0 and args[0] == "--dry-run") or os.environ.get("CONSOLEONLY", False): # noqa
if (len(args) > 0 and args[0] == "--dry-run") or os.environ.get(
"CONSOLEONLY", False
): # noqa
print(url)
else:
webbrowser.open_new_tab(url)


def _get_pullrequest_url(name, branch):
print("pullrequest", name, branch)
if repo == "github":
url = "https://github.com/" + name + "/pull/new/" + branch
if fork_pr_strategy == "private":
url = f"https://github.com/{name}/compare/{master_branch}...{branch}"
else:
url = "https://github.com/" + name + "/pull/new/" + branch
elif repo == "bitbucket":
url = "https://bitbucket.org/" + name + "/pull-requests/new?t=1&source=" + branch # noqa
url = (
"https://bitbucket.org/" + name + "/pull-requests/new?t=1&source=" + branch
) # noqa
return url


Expand Down

0 comments on commit f10f38c

Please sign in to comment.