Strict Concurrency #109
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| Pod::Spec.new do |s| | ||
| s.name = 'TinyConstraints' | ||
| s.version = '5.0.0' | ||
| s.swift_versions = [5.0] | ||
| s.summary = 'TinyConstraints is the syntactic sugar that makes Auto Layout sweeter for human use.' | ||
| s.description = <<-DESC | ||
|
|
@@ -11,8 +11,8 @@ TinyConstraints is the syntactic sugar library that makes Auto Layout sweeter fo | |
| s.author = { 'Robert-Hein Hooijmans' => '[email protected]' } | ||
| s.source = { :git => 'https://github.com/roberthein/TinyConstraints.git', :tag => s.version.to_s } | ||
| s.social_media_url = 'https://twitter.com/roberthein' | ||
| s.ios.deployment_target = '15.0' | ||
| s.tvos.deployment_target = '15.0' | ||
| s.osx.deployment_target = '10.15' | ||
| s.source_files = 'TinyConstraints/Classes/**/*.{swift}' | ||
| end | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -31,13 +31,13 @@ | |||||||
| public typealias Constraint = NSLayoutConstraint | ||||||||
| public typealias Constraints = [Constraint] | ||||||||
|
|
||||||||
| public enum ConstraintRelation: Int, Sendable { | ||||||||
| case equal = 0 | ||||||||
| case equalOrLess = -1 | ||||||||
| case equalOrGreater = 1 | ||||||||
| } | ||||||||
|
|
||||||||
| @MainActor public extension Collection where Iterator.Element == Constraint { | ||||||||
|
There was a problem hiding this comment. Strongly recommend the following instead:
Suggested change
This makes it so that existing code that doesn't yet have strict concurrency enabled can use this library version without having to make changes to their code. |
||||||||
|
|
||||||||
| func activate() { | ||||||||
|
|
||||||||
|
|
@@ -55,7 +55,7 @@ public extension Collection where Iterator.Element == Constraint { | |||||||
| } | ||||||||
|
|
||||||||
| #if os(OSX) | ||||||||
| @MainActor public extension Constraint { | ||||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||||
| @objc | ||||||||
| func with(_ p: Constraint.Priority) -> Self { | ||||||||
| priority = p | ||||||||
|
|
@@ -68,7 +68,7 @@ public extension Constraint { | |||||||
| } | ||||||||
| } | ||||||||
| #else | ||||||||
| @MainActor public extension Constraint { | ||||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||||
| @objc | ||||||||
| func with(_ p: LayoutPriority) -> Self { | ||||||||
| priority = p | ||||||||
|
|
||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |||||
| import UIKit | ||||||
| #endif | ||||||
|
|
||||||
| @MainActor public extension TinyView { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| @discardableResult | ||||||
| func stack(_ views: [TinyView], axis: ConstraintAxis = .vertical, width: CGFloat? = nil, height: CGFloat? = nil, spacing: CGFloat = 0) -> Constraints { | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,7 +25,7 @@ | |||||
| #if os(OSX) | ||||||
| import AppKit | ||||||
|
|
||||||
| @MainActor public extension TinyView { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| @discardableResult | ||||||
| func edgesToSuperview(excluding excludedEdge: LayoutEdge = .none, insets: TinyEdgeInsets = .zero, usingSafeArea: Bool = false) -> Constraints { | ||||||
|
|
@@ -53,7 +53,7 @@ | |||||
| #else | ||||||
| import UIKit | ||||||
|
|
||||||
| @MainActor public extension TinyView { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| @available(tvOS 10.0, *) | ||||||
| @available(iOS 10.0, *) | ||||||
|
|
@@ -150,7 +150,7 @@ | |||||
| } | ||||||
| #endif | ||||||
|
|
||||||
| public struct LayoutEdge: OptionSet, Sendable { | ||||||
| public let rawValue: UInt8 | ||||||
| public init(rawValue: UInt8) { | ||||||
| self.rawValue = rawValue | ||||||
|
|
@@ -164,7 +164,7 @@ public struct LayoutEdge: OptionSet { | |||||
| public static let none = LayoutEdge(rawValue: 1 << 6) | ||||||
| } | ||||||
|
|
||||||
| @MainActor public extension TinyView { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| private func safeConstrainable(for superview: TinyView?, usingSafeArea: Bool) -> Constrainable { | ||||||
| guard let superview = superview else { | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |||||
| import UIKit | ||||||
| #endif | ||||||
|
|
||||||
| @MainActor public extension Constrainable { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| @discardableResult | ||||||
| func center(in view: Constrainable, offset: CGPoint = .zero, priority: LayoutPriority = .required, isActive: Bool = true) -> Constraints { | ||||||
|
|
@@ -339,7 +339,7 @@ public extension Constrainable { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| @MainActor public extension TinyView { | ||||||
|
There was a problem hiding this comment. Not needed since
Suggested change
|
||||||
|
|
||||||
| func setHugging(_ priority: LayoutPriority, for axis: ConstraintAxis) { | ||||||
| setContentHuggingPriority(priority, for: axis) | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |
| import UIKit | ||
| #endif | ||
|
|
||
| @MainActor extension TinyEdgeInsets { | ||
|
There was a problem hiding this comment. It's probably not recommended to add this since |
||
|
|
||
| public static func uniform(_ value: CGFloat) -> TinyEdgeInsets { | ||
| return TinyEdgeInsets(top: value, left: value, bottom: value, right: value) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed as the compiler infers
@MainActorisolation for all members declared on this extension sinceConstrainableis isolated to the@MainActor.