Issue #100 #109
Issue #100 #109
Conversation
There was a problem hiding this comment.
Hey William, welcome to the project.
I'll have to update the contribution guidelines, but I don't accept PRs from forks. The reason is that the Github Actions that we use to check correctness of code don't run on forks, they'll only run on branches of the main repo.
To get access to the main repo, feel free to hop on OSSU's Discord server and join our channel, then I'll give you access to the repo. Thanks!
| # X and Y directions that the character is facing. | ||
| facing_x: float | ||
| facing_y: float | ||
|
|
||
| def __init__(self, sprite_spec: spec.GameSpriteSpec): |
There was a problem hiding this comment.
Please put those back since we still have those fields.
|
I've added a guide on how to convert your fork into a branch here: https://github.com/robbrit/ossu-game-project-1#prs-from-forks However you won't be able to do that until you're added as a collaborator to this project, and to do that please send me a message on Discord. |
|
Hey sorry for the delayed response; I've joined the discord but I'm struggling to find your account. What is your discord username? |
|
My username on there is currently RobGPT, although it's usually Rob. Don't ask :) |
Hello,
This is my first pull request so I apologize if there is anything I missed in terms of request etiquette. I've completed the additions described in Issue #100 to the best of my knowledge; please let me know if I've missed anything.
Thank you.