Skip to content

build(deps): bump github.com/twmb/franz-go from 1.19.3 to 1.19.5 #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 3, 2025

Bumps github.com/twmb/franz-go from 1.19.3 to 1.19.5.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.19.5

Fixes a bug introduced in 1.19.3 that caused batched FindCoordinator requests to no longer work against older brokers (Kafka brokers before 2.4, or all Redpanda versions brokers).

All credit to @​douglasbouttell for exactly diagnosing the bug.

  • 06272c66 bugfix kgo: bugfix batched FindCoordinator requests against older brokers

v1.19.4

Fixes one bug introduced from the prior release (an obvious data race in retrospect), and one data race introduced in 1.19.0. I've looped the tests more in this release and am not seeing further races. I don't mean to downplay the severity here, but these are races on pointer-sized variables where reading the before or after state is of little difference. One of the read/write races is on a context.Context, so there are actually two pointer sized reads & writes -- but reading the (effectively) type vtable for the new context and then the data pointer for the old context doesn't really break things here. Anyway, you should upgrade.

This also adds a workaround for Azure EventHubs, which does not handle ApiVersions correctly when the broker does not recognize the version we are sending. The broker should reply with an UNSUPPORTED_VERSION error and reply with the version the broker can handle. Instead, Azure is resetting the connection. To workaround, we detect a cxn reset twice and then downgrade the request we send client side to 0.

  • 7910f6b6 kgo: retry connection reset by peer from ApiVersions to work around EventHubs
  • d310cabd kgo: fix data read/write race on ctx variable
  • 7a5ddcec kgo bugfix: guard sink batch field access more
Commits
  • 37eecbb Merge pull request #1036 from twmb/change
  • 9b3e28b note incoming 1.19.5
  • 2ba8310 Merge pull request #1035 from twmb/1034
  • 06272c6 kgo: bugfix batched FindCoordinator requests against older brokers
  • ef502bc kgo: add fatcontext, address some lints
  • 3836e2c Merge pull request #1033 from twmb/readme
  • b17fa8f README: update first bullet pt
  • 12af197 Merge pull request #1032 from twmb/lag
  • 108520d kadm: bump deps, new APIs to support better lag
  • d39445d Merge pull request #1031 from peczenyj/fix-go-generate
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.19.3 to 1.19.5.
- [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
- [Commits](twmb/franz-go@v1.19.3...v1.19.5)

---
updated-dependencies:
- dependency-name: github.com/twmb/franz-go
  dependency-version: 1.19.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from rustatian June 3, 2025 04:13
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 3, 2025

The reviewers field in the dependabot.yml file will be removed soon. Please use the code owners file to specify reviewers for Dependabot PRs. For more information, see this blog post.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 3, 2025
Copy link

coderabbitai bot commented Jun 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 11, 2025

Looks like github.com/twmb/franz-go is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jun 11, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/twmb/franz-go-1.19.5 branch June 11, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant