-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 3: updates to @famoser's fork #25
base: master
Are you sure you want to change the base?
Conversation
…with Psr\Log\LoggerInterface
Thanks for the contribution! |
I guess you would either need two "master branches", i.e. master-sf3 and master-sf2, or if perhaps tagging/versioning the current state would also work. PS: I suppose you reacted to a notification about my lastest commit (cc508e7). That should probably not be included in the bundle, as it is a fix for my project specifically. I'm needing the u-number instead of the whole email address as a user name. However, since my fork is a fork of your fork, I didn't manage to require it as a separate branch in my composer.json file, so I pushed it to my master branch. |
famoser's fork causes the following error
Symfony\Component\HttpKernel\Log\LoggerInterface is deprecated since Symfony 2.2 (http://api.symfony.com/2.8/Symfony/Component/HttpKernel/Log/LoggerInterface.html) and has been removed in Symfony 3.0, causing this error.
It should use Psr\Log\LoggerInterface instead.
Also, Symfony\Component\Security\Core\SecurityContextInterface is declared, but never used.
Since I was not able to create an issue in famoser's fork, I created a separate fork for this.