Add priority option for repo configuration #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's no user-specified ordering for the defined repositories and because of the way the code works it will (counter intuitively) choose RPMs from repos later in the list. This change introduces an explicit repo priority so that users can force ordering of repos to choose RPMs from.
rmohr
reviewed
Jan 6, 2025
Now that we have the loading code exposed in a way that is a bit more manageable we can add some tests around it. We also add a set of helpers in a separate source file which will be used by tests for the reducer itself.
This change approximates the reducer operations and provides tests for them. It leverages the existing helpers produced for the loader_test to reduce the repetitiveness of constructing the test inputs.
The first iteration of this change produced a scenario where we'd drop packages that have a different version which we previously were retaining. This change fixes that and includes differently versioned packages while accounting for the repository priority otherwise.
There was a problem hiding this comment.
LGTM, I think this together with my stable solver setup will give the results we expect.
Let's wait a few days see if @rmohr has some time to look at it, otherwise I'll approve
Order makes sense, I just want to add that it should eventually use the newest versions matching a constraint, but yes if the same versions are shipped by two repos it just uses one of those kind of arbitrary. |
rmohr
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no user-specified ordering for the defined repositories and because of the way the code works it will (counter intuitively) choose RPMs from repos later in the list.
This change introduces an explicit repo priority so that users can force ordering of repos to choose RPMs from.