Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #363: Replace jQuery deprecated methods trim and isFunction #364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

melloware
Copy link

No description provided.

Copy link
Owner

@rmm5t rmm5t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by the need to use String.prototype.trim.call

jquery.timeago.js Outdated Show resolved Hide resolved
jquery.timeago.js Outdated Show resolved Hide resolved
jquery.timeago.js Outdated Show resolved Hide resolved
@melloware
Copy link
Author

All changes made...

@xPaw
Copy link

xPaw commented Nov 1, 2020

$.proxy is deprecated too, change it to refresh.bind(this);

@melloware
Copy link
Author

Thanks! Updated my PR please review.

@mix4242
Copy link

mix4242 commented Oct 12, 2021

Thanks @melloware for the PR and @rmm5t for the review! Could this be merged in, and a new release done, pretty please? The warnings from jquery-migrate we use are rather annoying 🙈

@melloware
Copy link
Author

@rmm5t any update on this? Looks like all activity on this repo has stopped? Do you need help maintaining it or releasing it to NPM?

@m-ober
Copy link

m-ober commented Apr 30, 2023

@rmm5t any update on this? Looks like all activity on this repo has stopped? Do you need help maintaining it or releasing it to NPM?

I just came here also by a console full of JQMigrate warnings. As almost a year has passed without feedback, maybe you want to create a fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants