Fix panic for custom string type

rliebz · Mar 7, 2024 · 2ae6fa4 · 2ae6fa4
1 parent 1ca46c5
commit 2ae6fa4
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/be/assertions.go b/be/assertions.go
@@ -137,8 +137,8 @@ want: %v
 `,
 				argGot,
 				argWant,
-				quoteString(interface{}(got).(string)),
-				quoteString(interface{}(want).(string)),
+				quoteString(reflect.ValueOf(got).String()),
+				quoteString(reflect.ValueOf(want).String()),
 			),
 		}
 	}

diff --git a/be/assertions_test.go b/be/assertions_test.go
@@ -146,6 +146,8 @@ diff (-want +got):
 	})
 }
 
+type CustomString string
+
 func TestEqual(t *testing.T) {
 	t.Run("equal", func(t *testing.T) {
 		g := ghost.New(t)
@@ -310,6 +312,32 @@ diff (-want +got):
 		result.Message = strings.ReplaceAll(result.Message, "\u00a0", " ")
 		g.Should(be.Equal(result.Message, wantText))
 	})
+
+	t.Run("custom string type", func(t *testing.T) {
+		g := ghost.New(t)
+
+		type T struct {
+			A string
+			B int
+		}
+
+		got := CustomString("foo")
+		want := CustomString("bar")
+
+		result := be.Equal(got, want)
+		g.Should(be.False(result.Ok))
+		g.Should(be.Equal(result.Message, `got != want
+got:  "foo"
+want: "bar"
+`))
+
+		result = be.Equal(CustomString("foo"), CustomString("bar"))
+		g.Should(be.False(result.Ok))
+		g.Should(be.Equal(result.Message, `CustomString("foo") != CustomString("bar")
+got:  "foo"
+want: "bar"
+`))
+	})
 }
 
 func TestError(t *testing.T) {