Skip to content

Commit

Permalink
Nnnn feather fixes
Browse files Browse the repository at this point in the history
- fixes feather not updating when size or visibility was changed.
- adds boolean isEnabled to keep the feather even if it is removed. When it is not enabled, it doesn't get exported for runtime.
- enables feathers on strokes

Diffs=
fcda031783 Nnnn feather fixes (#8924)

Co-authored-by: Alex Gibson <agibson.uk@gmail.com>
Co-authored-by: hernan <hernan@rive.app>
3 people committed Jan 27, 2025
1 parent 2a9ba98 commit 17fb8bd
Showing 2 changed files with 66 additions and 56 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6e30b9bb430926b63f0ed662b89250b033993c87
fcda031783b4d7e5bf2d983081cfe76ff60b1f57
120 changes: 65 additions & 55 deletions dev/defs/shapes/paint/feather.json
Original file line number Diff line number Diff line change
@@ -1,62 +1,72 @@
{
"name": "Feather",
"key": {
"int": 533,
"string": "feather"
"name": "Feather",
"key": {
"int": 533,
"string": "feather"
},
"extends": "container_component.json",
"properties": {
"spaceValue": {
"type": "uint",
"initialValue": "0",
"key": {
"int": 748,
"string": "spacevalue"
},
"description": "The transform space for the offset."
},
"strength": {
"type": "double",
"initialValue": "12",
"animates": true,
"key": {
"int": 749,
"string": "strength"
},
"bindable": true
},
"extends": "container_component.json",
"properties": {
"spaceValue": {
"type": "uint",
"initialValue": "0",
"key": {
"int": 748,
"string": "spacevalue"
},
"description": "The transform space for the offset."
"offsetX": {
"type": "double",
"initialValue": "0",
"animates": true,
"key": {
"int": 750,
"string": "offsetx"
},
"strength": {
"type": "double",
"initialValue": "12",
"animates": true,
"key": {
"int": 749,
"string": "strength"
},
"bindable": true
"description": "X offset of the feather.",
"bindable": true
},
"offsetY": {
"type": "double",
"initialValue": "0",
"animates": true,
"key": {
"int": 751,
"string": "offsety"
},
"offsetX": {
"type": "double",
"initialValue": "0",
"animates": true,
"key": {
"int": 750,
"string": "offsetx"
},
"description": "X offset of the feather.",
"bindable": true
"description": "Y offset of the feather.",
"bindable": true
},
"inner": {
"type": "bool",
"initialValue": "false",
"animates": true,
"key": {
"int": 752,
"string": "inner"
},
"offsetY": {
"type": "double",
"initialValue": "0",
"animates": true,
"key": {
"int": 751,
"string": "offsety"
},
"description": "Y offset of the feather.",
"bindable": true
"description": "Whether it's an inner shadow.",
"bindable": true
},
"isEnabled": {
"type": "bool",
"initialValue": "true",
"key": {
"int": 755,
"string": "isenabled"
},
"inner": {
"type": "bool",
"initialValue": "false",
"animates": true,
"key": {
"int": 752,
"string": "inner"
},
"description": "Whether it's an inner shadow.",
"bindable": true
}
"description": "Whether the feather is active or has been removed. We keep it to avoid losing the settings.",
"runtime": false
}
}
}
}

0 comments on commit 17fb8bd

Please sign in to comment.