Skip to content

Commit

Permalink
apply current state update before changing states
Browse files Browse the repository at this point in the history
Once a transition completes, we update the state without applying the advance to the currentState of the transition.
This PR checks whether a transition is complete to invoke apply to the complete state before moving to the next state.
Note: It could happen that the next state is actually the same one completed in the transition, so apply would be called twice on the same state.
Conceptually it makes sense to treat it as two different things, since one is in the context of the transition and the other "apply" is in the context of the new state. But in terms of performance, this might not be the best solution.

Diffs=
da14cc814 apply current state update before changing states (#6538)
  • Loading branch information
bodymovin committed Feb 1, 2024
1 parent 3ade834 commit 7d33e9e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ac0d97c1243ea3c2e473a319f4eb100fed52e1d5
da14cc81429ab78081030ec824f0796985af968d
2 changes: 1 addition & 1 deletion submodules/rive-cpp

0 comments on commit 7d33e9e

Please sign in to comment.