Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-export rive_rs #9

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

simbleau
Copy link
Contributor

Problem

Those who pull in rive-bevy shouldn't need to pull in rive-rs. By re-exporting the version of rive-rs, users following the example won't face issues and, for maintainability, the end-user doesn't need to ensure versions match.

Solution

  • Re-export rive_rs
  • Examples now use rive_bevy::rive_rs:_ instead of rive_rs::_ imports

@dragostis
Copy link
Contributor

Thanks for the PR. Seems like a good idea.

I'll take a look next week.

src/plugin.rs Outdated Show resolved Hide resolved
@simbleau
Copy link
Contributor Author

simbleau commented Dec 4, 2023

Good to go. @dragostis

@dragostis dragostis merged commit 378cef7 into rive-app:main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants