feat(wasm): experimental support for WASI #733
Draft
+165
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
skyzh
approved these changes
Nov 25, 2022
| @@ -13,7 +12,7 @@ pub struct DatabaseWrapper; | |||
| impl sqlplannertest::PlannerTestRunner for DatabaseWrapper { | |||
| async fn run(&mut self, test_case: &ParsedTestCase) -> Result<String, Error> { | |||
| if !test_case.tasks.is_empty() { | |||
| let db = Database::new_on_disk(SecondaryStorageOptions::default_for_test()).await; | |||
| let db = Database::new_in_memory(); | |||
There was a problem hiding this comment.
In-memory engine might not support predicate pushdown on table scan. I still want to keep new_on_disk with in-memory backend here.
|
I was working on some WASM-related things recently I would prefer compiling it using wasm-pack so that it can run in the browser. |
Just curious about what it is? (if not confidential) 👀 |
|
see prisma-engines :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Runji Wang [email protected]