Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot_data.rs #455

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add snapshot_data.rs #455

merged 2 commits into from
Jan 7, 2025

Conversation

Levi0804
Copy link
Contributor

@Levi0804 Levi0804 commented Jan 6, 2025

This PR handles #450.
Please let me know if there are any changes or improvements you'd like me to make.

Copy link
Contributor

@hai-rise hai-rise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit comments but the test runs well already, thanks!

crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
crates/pevm/tests/snapshot_data.rs Outdated Show resolved Hide resolved
@Levi0804
Copy link
Contributor Author

Levi0804 commented Jan 7, 2025

@hai-rise Thanks for reviewing the code! I've addressed all the changes you suggested.

@Levi0804 Levi0804 requested a review from hai-rise January 7, 2025 12:26
Copy link
Contributor

@hai-rise hai-rise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hai-rise hai-rise merged commit 71f6111 into risechain:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants