Skip to content

Fix --inst-limit #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Fix --inst-limit #805

merged 1 commit into from
Mar 18, 2025

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Mar 18, 2025 •
edited
Loading

caused by #748

Forgot to assign val to inst_limit after parsing cli params

@trdthg
Fix --inst-limit
62b9aa1 
Forgot to assign to inst_limit after parsing cli param
@github-actions GitHub Actions
Copy link

Test Results

396 tests  ±0   396 ✅ ±0   1m 18s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 62b9aa1. ± Comparison against base commit 646bbd8.

@jordancarlin jordancarlin added the will be merged Scheduled to be merged in a few days if nobody objects label Mar 18, 2025
Timmmm
Timmmm approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Timmmm Timmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops :-)

I guess we should have tests for the CLI... I don't think it's super critical though.

@Timmmm Timmmm merged commit c8f8a24 into riscv:master Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm approved these changes

@arichardson arichardson arichardson approved these changes

@jordancarlin jordancarlin jordancarlin approved these changes

Assignees
No one assigned
Labels
will be merged Scheduled to be merged in a few days if nobody objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trdthg @Timmmm @arichardson @jordancarlin