Skip to content

Change VROR_VI immediate field from imm to uimm #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Change VROR_VI immediate field from imm to uimm #1904

merged 1 commit into from
Mar 14, 2025

Conversation

nadime15
Copy link
Contributor

The Sail code for vror.vi uses imm instead of uimm, even though "uimm" is specified in the encoding.

A correct reference is vwsll.vi, which properly uses uimm.

Please cross-check the correctness of this proposed change.

aswaterman
aswaterman approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aswaterman aswaterman enabled auto-merge (squash) March 13, 2025 23:58
@aswaterman aswaterman merged commit 23d291d into riscv:main Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadime15 @aswaterman