Update Zicond instructions #452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkOpenly
approved these changes
Feb 3, 2025
dhower-qc
requested changes
Feb 3, 2025
arch/inst/Zicond/czero.eqz.yaml
Outdated
| XReg input2 = X[rs2]; | ||
| XReg output = 0; | ||
|
|
||
| if(input2 != 0) { |
There was a problem hiding this comment.
This is totally stylistic, but it might be more compact/readable using the ternary operator in a single line:
X[rd] = (X[rs2] == 0) ? 0 : X[rs1];
arch/inst/Zicond/czero.nez.yaml
Outdated
| XReg input2 = X[rs2]; | ||
| XReg output = 0; | ||
|
|
||
| if(input2 == 0) { |
There was a problem hiding this comment.
similar:
X[rd] = (X[rs2] != 0) ? 0 : X[rs1];(also, I think what you wrote here is backwards)
There was a problem hiding this comment.
It shouldn't be? Xreg = 0 unless the condition is NOT met. So the "if" in my case here would be the opposite of the instruction condition. Might seem counterintuitive I suppose but I'm pretty sure it's correct. Regardless, the more compact way you suggested is better and more readable, so I'll just change it to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated instructions in Zicond. Also fixed an error in the generated SAIL code that caused both instructions to have the same operation.