Add newly added f16 and f128 types in parsing #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
requested changes
Jul 19, 2024
There was a problem hiding this comment.
The change is fine. The compiler will tell the user that they can't use f128 just yet.
But I don't like the current implementation, neither for int suffices nor float. IMO it would be better to capture an ident and match the result. This reduces the chance of false positive matches like 1_u321.
|
Ok, merging this one and opening an issue. Gonna give it a try. :) |
|
Ah wait no, can't since you didn't approve. Gonna try in this PR then I suppose. 😛 |
Kijewski
approved these changes
Jul 19, 2024
|
Opening an issue then. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#116909