Clarify what request-header-size and response-header-size mean

Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.
ring-clojure · May 4, 2021 · 0a740f1 · 0a740f1
1 parent 99ece0b
commit 0a740f1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ring-jetty-adapter/src/ring/adapter/jetty.clj b/ring-jetty-adapter/src/ring/adapter/jetty.clj
@@ -203,8 +203,10 @@
  :need,:want or :none (defaults to :none)
  :send-date-header? - add a date header to the response (default true)
  :output-buffer-size - the response body buffer size (default 32768)
- :request-header-size - the maximum size of a request header (default 8192)
- :response-header-size - the maximum size of a response header (default 8192)
+ :request-header-size - the maximum size of the request line and headers
+ (i.e. the request protocol header) (default 8192)
+ :response-header-size - the maximum size of the response line and headers
+ (i.e. the response protocol header) (default 8192)
  :send-server-version? - add Server header to HTTP response (default true)"
  [handler options]
  (let [server (create-server (dissoc options :configurator))]