Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (Models): Escape non-standard table names #6903

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix (Models): Escape non-standard table names #6903

merged 2 commits into from
Mar 20, 2025

Conversation

ericpgreen2
Copy link
Contributor

Addresses this Slack report

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericpgreen2 ericpgreen2 requested a review from AdityaHegde March 17, 2025 14:14
@ericpgreen2 ericpgreen2 self-assigned this Mar 17, 2025
AdityaHegde
AdityaHegde requested changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We allow for a lot more chars in table names in backend https://github.com/rilldata/rill/blob/main/runtime/drivers/olap.go#L283

Perhaps we should do the same and always surround by quotes if it is not alpha-numeric.

@ericpgreen2 ericpgreen2 requested a review from AdityaHegde March 17, 2025 15:04
@ericpgreen2 ericpgreen2 changed the title fix (Models): Add quotes to table names with hypens fix (Models): Escape non-standard table names Mar 17, 2025
@ericpgreen2 ericpgreen2 merged commit e099392 into main Mar 20, 2025
9 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-quote-table-names-with-hyphens branch March 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @AdityaHegde