feat: Honor order of dimensions and measures from url param #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
reviewed
Mar 13, 2025
There was a problem hiding this comment.
A few code comments while awaiting Product UX feedback here
web-common/src/features/dashboards/state-managers/actions/measures.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/state-managers/actions/dimensions.ts
Outdated
Show resolved
Hide resolved
AdityaHegde
force-pushed
the
feat/url-param-dim-meas-order
branch
from
05609f2 to
9a53946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a precursor to allowing users to reorder dimensions and measures we need to make sure the order from url param is persisted.
This PR isolates the url param changes. Hiding/showing will append the measure/dimension.
Checklist: