Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .wav to supported file uploads #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lalabuy948
Copy link

Hi, I was looking for exactly for what your application does, but I faced weird issue when was trying to upload files from iPhone safari, I dived a bit into and added .wav support since it's not in the audio/* list.

https://www.iana.org/assignments/media-types/media-types.xhtml#audio

Hope you don't mind merging it.

@alexeynefdef
Copy link

Hey @lalabuy948, I had the same issue on my iPhone, but it works when you drag'n'drop the sample from files into browser (not select from files in browser), but I can only play those samples and they aren't in PO at the end.

@rileyjshaw
Copy link
Owner

Hi @lalabuy948, I’m sorry for the delay! Thanks for the contribution - I’ll be happy to merge this change.

Before I merge it, are you able to test to make sure .wav files still aren’t included in audio/* in the latest iOS?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants