Fix plugin jekyll-seo-tag #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I am back with another pull request. Recently I realized that the plugin jekyll-seo-tag was not properly inserting its SEO tags on my personal website using this theme. I traced the issue back to commit 5563cd9 by yagarea on 02.03.2024. In this commit, they edited
_includes/head.htmlby enclosing the{% seo %}line with a{% comment %}. The commit message says this was done "because [jekyll-seo-tag] does not escape strings". However, this current solution completely breaks the functionality of the jekyll-seo-tag plugin.I have attached a commit which removes the comment lines and fixes this issue.
Best regards, Luuk