Remove compiled CSS #109
Open
Remove compiled CSS #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, ran into this same issue and came to the same conclusion. i am a frontend n00b and had difficulty figuring this out, i think this merge is helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am not a Jekyll expert, but as far as I understand, Jekyll themes should have no compiled CSS (
*.cssor*.css.map) in their source repositories. Jekyll should generate these files when building the site from the SASS files (*.scss) of the theme.Since commit 2f1e4d4 by tanvincible on 28.12.2024, there has been compiled CSS in the source repository for no-style-please under assets/css/.
I have a personal site which uses this theme. For this site, I implemented some custom SASS under
assets/css/main.scss. Since the commit mentioned above, this custom SASS has been ignored when building the site. My guess is the compiler (Github Pages) only looks at the compiled CSS in this folder and skips my custom SASS.This pull request consists of a single commit in which the compiled CSS files in question are deleted. Additionally, the extensions of the compiled CSS files is added to
.gitignore. This is to prevent the inclusion of these files in the source repository in the future.I have tested this code with my personal site and it seems to alleviate the issue.
Regards, Luuk