Fix: frame dependency calculation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalzoo
force-pushed
the
75-frame-dependencies
branch
from
fd4785c
to
a2acfb9
Compare
kalzoo
force-pushed
the
75-frame-dependencies
branch
from
a2acfb9
to
11a8e97
Compare
genos
reviewed
Jun 2, 2022
src/program/graph.rs
Outdated
| /// | ||
| /// If the frame is currently blocked by other nodes, it will add itself to the list of blockers, | ||
| /// much like a reader in a read-write lock. | ||
| pub fn register_blocker(&mut self, node: ScheduledGraphNode) -> Option<ScheduledGraphNode> { |
There was a problem hiding this comment.
I can't think of a better name, so maybe ignore this, but I think a more suggestive function name that says something about returning self.using might be helpful.
I suppose I have a similar (-ly unhelpful) note for register_user's naming, too.
There was a problem hiding this comment.
Changed - what do you think?
|
Note: this fails the example cited in this issue; if the spec remains unchanged, this will have to be modified. |
notmgsk
reviewed
Jun 7, 2022
notmgsk
approved these changes
Jun 7, 2022
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix, back to back with #73.
Closes #75
This takes the approach of tracking the instructions which use and block a frame separately, solving the problems described in #75. It's more complex, but should still remain readable and maintainable. This PR includes a couple more snapshot test cases to illustrate the differences and prevent regression.