Add basic unit tests for CI #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to run this tool along other tools in a single process using riemann-wrapper.
* Use a Gemfile / .gemspec file for bunder; * Drop the extension of Rakefile.rb to follow current conventions; * Drop now useless tooling from the Rakefile; * Make the version of the gem available from the code. These changes are supposed to introduce no functional change, and are intended to make it easier to manage the module code.
For now, disable unit tests because we don't have unit tests.
PG::Error is a kind of StandardError, here we want to catch this kind of exception. The error was reported by Rubocop.
|
@jamtur01 sorry to ping you once again for a riemann-tool project 😄 I completely forgot this work, and today I was thinking "we really need a riemann-tool that can monitor PostgreSQL". Due to this being WIP, it is not part of our monitoring, and probably should! Do you mind reviewing this PR (and the other ones included in this one)? Feel free to invite me as a contributor to the project so that I can help maintaining it if you are willing to. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to detect regressions, we need at least basic unit tests.
This have been tested here: smortex#1
This PR also include: