Enable large file support for Linux by default #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the file I/O configuration in miniz_zip.c to automatically enable large file support on Linux systems. The changes include: 1. Added proper Linux platform detection using standard macros: __linux__, __linux, linux, and __gnu_linux__ 2. Removed the warning message about potential lack of large file support on Linux 3. Used standard file functions (fopen, ftello, fseeko, stat) instead of *64 variants since _FILE_OFFSET_BITS=64 is defined during compilation 4. Added necessary header includes (<sys/stat.h> and <stdio.h>) for proper function declarations 5. Maintained backward compatibility with other platforms When _FILE_OFFSET_BITS=64 is defined (which it is in our build configuration), the standard file functions automatically become 64-bit capable on Linux systems. This eliminates the need for explicit *64 function variants and ensures transparent large file support. The modification ensures that miniz can handle files larger than 2GB on Linux systems without any code changes or special configuration, providing better out-of-the-box experience for Linux users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the file I/O configuration in miniz_zip.c to automatically enable large file support on Linux systems. The changes include:
When _FILE_OFFSET_BITS=64 is defined (which it is in our build configuration), the standard file functions automatically become 64-bit capable on Linux systems. This eliminates the need for explicit *64 function variants and ensures transparent large file support.
The modification ensures that miniz can handle files larger than 2GB on Linux systems without any code changes or special configuration, providing better out-of-the-box experience for Linux users.