support commands specified as exe/args #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the quick PR. I'll check this soon. |
rhysd
requested changes
Nov 22, 2024
process.go
Outdated
| if exeArgs, _ := shellwords.Parse(exe); len(exeArgs) > 0 { | ||
| // We want to return the original error if this command isn't found so | ||
| // do not overwrite it. | ||
| if p, err2 := execabs.LookPath(exeArgs[0]); err2 == nil { |
There was a problem hiding this comment.
Suggested change
| if p, err2 := execabs.LookPath(exeArgs[0]); err2 == nil { | |
| if p, err := execabs.LookPath(exeArgs[0]); err == nil { |
Would you shadow the outer err variable? It is okay because this variable is very short-lived.
process_test.go
Outdated
| func TestProcessRunWithArgs(t *testing.T) { | ||
| var done atomic.Bool | ||
| p := newConcurrentProcess(1) | ||
| echo := testSkipIfNoCommand(t, p, "echo hello") |
There was a problem hiding this comment.
This test doesn't fail when newCommandRunner fails because it calls t.Skip.
Instead, we need to check if echo exists separately.
if _, err := execabs.LookPath("echo"); err != nil {
t.Skipf("echo command is necessary to run this test: %s", err)
}
c, err := p.newCommandRunner("echo hello", false)
if err != nil {
t.Fatalf(`parsing "echo hello" failed: %v`, err)
}
|
Thanks @rhysd applied the fixes |
rhysd
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #480
If an external command (shellcheck, pyflakes) is not found, try to parse it as a exe+args using go-shellwords, which can allow executing without having the binary installed i.e.,
go run github.com/wasilibs/go-shellcheck/cmd/[email protected],pipx run pyflakes.