add download-path output to actions/download-artifact@v3 for work…

…around of (#442)
rhysd · Sep 29, 2024 · d339f6e · d339f6e
1 parent 874bf89
commit d339f6e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/popular_actions.go b/popular_actions.go
diff --git a/scripts/generate-popular-actions/main.go b/scripts/generate-popular-actions/main.go
@@ -191,6 +191,19 @@ func (g *gen) fetchRemote() (map[string]*actionlint.ActionMetadata, error) {
 			}
 		}
 
+		// Workaround for #442.
+		// Once this issue is fixed or the `download-artifact@v3" is completely obsolete (due to unsupported runner),
+		// remove this `if` statement and regenerate popular_actions.go.
+		// https://github.com/actions/download-artifact/issues/355
+		if f.spec == "actions/download-artifact@v3" {
+			if f.meta.Outputs == nil {
+				f.meta.Outputs = actionlint.ActionMetadataOutputs{}
+			}
+			f.meta.Outputs["download-path"] = &actionlint.ActionMetadataOutput{
+				Name: "download-path",
+			}
+		}
+
 		ret[f.spec] = f.meta
 	}
 

diff --git a/testdata/ok/issue-442.yaml b/testdata/ok/issue-442.yaml
@@ -0,0 +1,9 @@
+on: push
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/download-artifact@v3
+        id: dl
+      - run: echo "Download path is ${{ steps.dl.outputs.download-path}}"