Merge pull request #198 from rhpvorderman/issue194

Properly name percentiles in sequence length distribution
rhpvorderman · Oct 4, 2024 · be61aa6 · be61aa6
2 parents fb63df7 + 5b6aaa6
commit be61aa6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -9,6 +9,8 @@ Changelog
 
 version 0.12.0-dev
 ------------------
++ Properly name percentiles as such in the sequence length distribution rather
+  than using N50 nomenclature which is not correct.
 + Fix a bug where BAM files with missing quality sequences were inproperly 
   handled.
 + Update internal UniVec database to version from November 21st 2023.

diff --git a/src/sequali/report_modules.py b/src/sequali/report_modules.py
@@ -499,15 +499,16 @@ def distribution_table(self):
             return ""
         return f"""
             <table>
-                <tr><td>N1</td><td style="text-align:right;">{self.q1:,}</td></tr>
-                <tr><td>N5</td><td style="text-align:right;">{self.q5:,}</td></tr>
-                <tr><td>N10</td><td style="text-align:right;">{self.q10:,}</td></tr>
-                <tr><td>N25</td><td style="text-align:right;">{self.q25:,}</td></tr>
-                <tr><td>N50</td><td style="text-align:right;">{self.q50:,}</td></tr>
-                <tr><td>N75</td><td style="text-align:right;">{self.q75:,}</td></tr>
-                <tr><td>N90</td><td style="text-align:right;">{self.q90:,}</td></tr>
-                <tr><td>N95</td><td style="text-align:right;">{self.q95:,}</td></tr>
-                <tr><td>N99</td><td style="text-align:right;">{self.q99:,}</td></tr>
+                <tr><th>Percentile</th><th>Read length</th></tr>
+                <tr><td>1</td><td style="text-align:right;">{self.q1:,}</td></tr>
+                <tr><td>5</td><td style="text-align:right;">{self.q5:,}</td></tr>
+                <tr><td>10</td><td style="text-align:right;">{self.q10:,}</td></tr>
+                <tr><td>25</td><td style="text-align:right;">{self.q25:,}</td></tr>
+                <tr><td>50</td><td style="text-align:right;">{self.q50:,}</td></tr>
+                <tr><td>75</td><td style="text-align:right;">{self.q75:,}</td></tr>
+                <tr><td>90</td><td style="text-align:right;">{self.q90:,}</td></tr>
+                <tr><td>95</td><td style="text-align:right;">{self.q95:,}</td></tr>
+                <tr><td>99</td><td style="text-align:right;">{self.q99:,}</td></tr>
             </table>
         """