Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-4051: Update telemeter metrics allow-list #711

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

xperimental
Copy link
Contributor

Continuation of #702 after including openshift/cluster-monitoring-operator#2529.

@juzhao
Copy link

juzhao commented Dec 6, 2024

/test circleci: tests

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xperimental
Copy link
Contributor Author

/test circleci: tests

@xperimental
Copy link
Contributor Author

@philipgough Is there anything I can do on this PR?

@philipgough
Copy link
Contributor

hey @xperimental - sorry I missed this ping. Feel free to grab me on Slack next time if I don't respond because "too many notifications".

Let me take a look!

@philipgough
Copy link
Contributor

For some reason, there is a repeated flag for compactor in ci which is preventing it from becoming ready

      containers:
      - args:
        - compact
        - --wait
        - --log.level=info
        - --log.format=logfmt
        - --objstore.config=$(OBJSTORE_CONFIG)
        - --data-dir=/var/thanos/compact
        - --debug.accept-malformed-index
        - --retention.resolution-raw=14d
        - --retention.resolution-5m=1s
        - --retention.resolution-1h=1s
        - --delete-delay=48h
        - --compact.concurrency=1
        - --downsample.concurrency=1
        - --deduplication.replica-label=replica
        - --debug.max-compaction-level=3
        - --compact.concurrency=1
        - --downsample.concurrency=1
        - --downsampling.disable

@philipgough philipgough merged commit e320505 into rhobs:main Jan 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants