Skip to content

Commit

Permalink
Add prefix to nip.io
Browse files Browse the repository at this point in the history
  • Loading branch information
rgaiacs committed Jan 27, 2025
1 parent 18f07a7 commit 5aac0e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions config/localhost.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ binderhub:
config:
BinderHub:
# Use Kubernetes DNS
hub_url: http://jupyterhub.127.0.0.1.nip.io
hub_url: http://jupyterhub.mybinder.127.0.0.1.nip.io
use_registry: false
image_prefix: dummy.io/localhost/binder-

extraConfig:
# Disable send events to StackDriver on Google Cloud
Expand All @@ -22,12 +23,12 @@ binderhub:
# This is unsafe! Only se for local development
enabled: false
hosts:
- 127.0.0.1.nip.io
- mybinder.127.0.0.1.nip.io

jupyterhub:
ingress:
hosts:
- jupyterhub.127.0.0.1.nip.io
- jupyterhub.mybinder.127.0.0.1.nip.io

static:
ingress:
Expand Down
6 changes: 3 additions & 3 deletions deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,11 @@ def deploy(release, name=None, dry_run=False, diff=False, ip_address=None, disab
helm.extend(
[
"--set",
f"binderhub.config.BinderHub.hub_url=http://jupyterhub.{ip_address}.nip.io",
f"binderhub.config.BinderHub.hub_url=http://jupyterhub.mybinder.{ip_address}.nip.io",
"--set",
f"binderhub.ingress.hosts={{{ip_address}.nip.io}}",
f"binderhub.ingress.hosts={{mybinder.{ip_address}.nip.io}}",
"--set",
f"binderhub.jupyterhub.ingress.hosts={{jupyterhub.{ip_address}.nip.io}}",
f"binderhub.jupyterhub.ingress.hosts={{jupyterhub.mybinder.{ip_address}.nip.io}}",
"--set",
f"static.ingress.hosts={{static.{ip_address}.nip.io}}",
]
Expand Down

0 comments on commit 5aac0e0

Please sign in to comment.