Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased revery-ui/esy-skia on top of mono/skia
Since their is a 10k diff we might copy master in new branch (to not break user that haven't updated because commit are kept)
and I force push the rebased branch in place of master
Question: in drawString method we have a textEncoding and we use always GlyphId (in one test we use Utf8) should we expose textEncoding arguments ?
todo: remove Deprecated module ? (I don't see any mention of a deprecation so it should be fine)
real diff https://github.com/revery-ui/revery/pull/926/files/ffb4669cb639e7cf217292e85bdc0bda0ee472c2..8638b97f3e0a0e620c9c6a5010f4bf15ee4fbbfc (the first one only change resolutions)