Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make webhook creation optional #570

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

Nabhag8848
Copy link
Contributor

@Nabhag8848 Nabhag8848 commented May 15, 2024

Description

  • Create SvixAccount only when webhooks enabled per environment - (accountId_environment) ie: accountId_production .
  • Endpoints for Get SvixAcc, Create SvixAcc, Create Consumer MagicLink.
  • Handling Cases for Svix Account for connection.created and connection.deleted
  • OnSuccesful Creation of App and Webhooks enabled - Show Toast
  • Delete Associated SvixAccount on Deletion of User from Clerk

Refactor and Errors Solved

  • Now we Support Link Navigation with Every New Tab.
  • We have Providers Account, Svix and Environment which can be used across Any Child Components - Fetching got easier, No Need to do it everytime.
  • Solve the errors for every tab which was there in console.
  • Before for every tab Account and Environment were getting fetched which is overkill
  • Improved /home to look little more appealing and added Explore Integration -> Link to docs
  • When there is no Evironment During Dev (NoRevertAccess) -> CreateApp was showing which is now solved.
  • don't copy key to clipboard when visiblity is changed
  • Analytics List wasn't having key in map function.

Closes #545

Things to take care, breaking changes and Edge Cases

  • [Resolved] Will Later , can we create the workspace with same name ?
  • svixAppid in Prod.
  • When webhooks is not enabled don't fire any event including connection.created , connection.deleted but by default who are using this event they should get enabled.
  • svixAppId associated with deletion of user from clerk should get deleted.
  • [Resolved] In Prod all the endpoints are created on only one environment - one svix application

DX Improvement

  • Added Intercom Test AppId provided by Intercom in .env.example

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking Changes
  • Bugs Fixes
  • Refactor

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Demo

Support Link Navigation.

Screen.Recording.2024-05-21.at.17.18.37.mov

Don't Copy to Clipboard when user means to change visiblity.

Screen.Recording.2024-05-21.at.17.19.24.mov

Toast On Creation of App Including Changing Uppercase Text to Capitalize in Buttons.

Screen.Recording.2024-05-21.at.17.21.00.mov

Overview of Webhooks Dashboard Capabilities.

Screen.Recording.2024-05-21.at.17.22.02.mov

Enable Webhooks per Environment Demo.

Screen.Recording.2024-05-21.at.17.25.25.mov

Demo of Event Trigger if Webhooks is Enabled per Environment

Screen.Recording.2024-05-21.at.17.31.00.mov

Delete All Associated SvixAccount When User is Deleted from Clerk

Screen.Recording.2024-05-21.at.17.56.12.mov

Copy link

vercel bot commented May 15, 2024

@Nabhag8848 is attempting to deploy a commit to the OpenInt Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented May 15, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@Nabhag8848 Nabhag8848 marked this pull request as ready for review May 21, 2024 13:56
@jatinsandilya jatinsandilya self-requested a review May 30, 2024 03:05
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:08am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE-REVERT]: Make webhook creation optional
1 participant