Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code + add support for multinode clusters #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mnaser
Copy link

@mnaser mnaser commented Jan 24, 2024

This is a big refactor that covers a few things:

  1. Refactor to use molecule-plugins for the Docker bits, so we don't have to keep a local copy of these, relying on the Docker driver instead to do the heavy lifting for us.
  2. Fix all of the tests so that they are all passing
  3. Implement the ability to have multi-node KinD clusters that you can define inside platforms with different roles and labels
  4. Add testing to make sure both old existing clusters and new multinode clusters code still works fine
  5. Improved login support so now login can login to any of the kind nodes in multinode scenario

Indirectly, it also fixes #1 which means you can actually run against the target containers (and that's tested in the code with the ping that is being done against them all).

Thanks! Would appreciate a release once you merge this if it is all good :)

@mnaser
Copy link
Author

mnaser commented Jan 26, 2024

@retr0h do you mind pressing the button to run tests if you have a second? :)

@mnaser
Copy link
Author

mnaser commented Jan 28, 2024

ahh, darn, the newer images of KinD don't have any python.. do you think i should install it out of the box or do it in the prepare step and then users can override that?

@retr0h
Copy link
Owner

retr0h commented Jan 28, 2024

ahh, darn, the newer images of KinD don't have any python.. do you think i should install it out of the box or do it in the prepare step and then users can override that?

Not sure, but looks like unit tests are failing, doesn't look related to kind images not having python.

@mnaser
Copy link
Author

mnaser commented Jan 31, 2024

The unit tests run a whole molecule scenario 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate the 'ansible_connection' so a role can interact with the container itself
2 participants